trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1221: [TRAFODION-2729] Fix bug reading reg...
Date Wed, 30 Aug 2017 21:26:33 GMT
GitHub user DaveBirdsall opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/1221

    [TRAFODION-2729] Fix bug reading region keys for hbase _ROW_, _CELL_ access

    At compile time, the NATable layer has logic to construct a metadata definition when accessing
native HBase tables via HBASE."_ROW_".objectName and HBASE."_CELL_".objectName syntax. Unfortunately,
when calling the HBase client routines to read region key information, the HBASE._ROW_ and
HBASE._CELL_ prefixes were passed down as part of the object name. So of course HBase could
not find the object, and the Trafodion compiler would think there was only one region in the
object. That would result in serial plans, even in the presence of cardinality hints.
    
    The fix is to check for HBASE._ROW_ and HBASE._CELL_ prefixes, and if present, not pass
them down to HBase when reading region keys.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaveBirdsall/incubator-trafodion Trafodion2729

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/1221.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1221
    
----
commit edbe1cce9106efac40c0efa9cb2193baca1acf64
Author: Dave Birdsall <dbirdsall@apache.org>
Date:   2017-08-30T21:22:11Z

    [TRAFODION-2729] Fix bug reading region keys for hbase _ROW_ and _CELL_ access

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message