trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1377: [TRAFODION-2889] Add Examples of LOAD Statemen...
Date Mon, 08 Jan 2018 03:57:34 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1377#discussion_r160072865
  
    --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_utilities.adoc ---
    @@ -650,6 +650,111 @@ Tables must be created/dropped/altered through Hive itself.
     [[load_examples]]
     === Examples of LOAD
     
    +* This example demonstrates the LOAD statement continues loading data from source_table
into target_table after ignorable data conversion error.
    --- End diff --
    
    Grammar is not quite right... adding the word "how" just before "the LOAD statement" will
fix it. But this doesn't quite match the content below... the content shows what happens when
we don't supply CONTINUE ON ERROR, then it shows a contrasting example with CONTINUE ON ERROR.
Possible wordsmith: "The examples below demonstrate how the LOAD statement behaves without
and with CONTINUE ON ERROR, when ignorable data conversion errors occur."


---

Mime
View raw message