trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1377: [TRAFODION-2889] Add Examples of LOAD Statemen...
Date Mon, 08 Jan 2018 03:57:33 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1377#discussion_r160072925
  
    --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_utilities.adoc ---
    @@ -650,6 +650,111 @@ Tables must be created/dropped/altered through Hive itself.
     [[load_examples]]
     === Examples of LOAD
     
    +* This example demonstrates the LOAD statement continues loading data from source_table
into target_table after ignorable data conversion error.
    +
    ++ 
    +Suppose that we have two tables (source_table and target_table) like this:
    +
    ++
    +```
    +SQL>SELECT * FROM source_table; 
    +A            B   
    +-----------  ----
    +
    +          1  aaaa
    +          2  bbbb
    +          3  cccc
    +          4  dd  
    +          5  ee  
    +          6  fff 
    +--- 6 row(s) selected.
    +
    +SQL>SHOWDDL source_table;
    +CREATE TABLE TRAFODION.SEABASE.SOURCE_TABLE
    +  ( 
    +    A                                INT DEFAULT NULL NOT SERIALIZED
    +  , B                                CHAR(4) CHARACTER SET ISO88591 COLLATE
    +      DEFAULT DEFAULT NULL NOT SERIALIZED
    +  )
    + ATTRIBUTES ALIGNED FORMAT 
    +;
    +--- SQL operation complete.
    +
    +SQL>SELECT * FROM target_table;
    +--- 0 row(s) selected.
    +
    +SQL>SHOWDDL target_table; 
    +CREATE TABLE TRAFODION.SEABASE.TARGET_TABLE
    +  ( 
    +    A                                INT DEFAULT NULL NOT SERIALIZED
    +  , B                                CHAR(3) CHARACTER SET ISO88591 COLLATE
    +      DEFAULT DEFAULT NULL NOT SERIALIZED
    +  )
    + ATTRIBUTES ALIGNED FORMAT 
    +;
    +--- SQL operation complete.
    +```
    +
    ++
    +Load data from source_table into target_table when `CONTINUE ON ERROR` is not specified,
the operation fails with data conversion error.
    --- End diff --
    
    Grammar. Suggest replacing "Load data..." with "When loading data...". Also "a data conversion
error" is slightly better.


---

Mime
View raw message