trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] trafodion pull request #1504: [TRAFODION-3009] Streamline error handling in ...
Date Tue, 03 Apr 2018 19:59:34 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1504#discussion_r178944088
  
    --- Diff: core/sql/executor/ExExeUtilExplain.cpp ---
    @@ -237,8 +237,7 @@ short ExExeUtilDisplayExplainTcb::work()
     	      executeImmediate("control session 'EXPLAIN' 'ON';");
     	    if (retcode < 0)
     	      {
    -		cliInterface()->retrieveSQLDiagnostics(getDiagsArea());
    -
    +                setDiagsArea(cliInterface()->allocAndRetrieveSQLDiagnostics(getDiagsArea()));
    --- End diff --
    
    Yes. I could do that for ExExeUtilTcb portion of the code.  


---

Mime
View raw message