trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] trafodion pull request #1504: [TRAFODION-3009] Streamline error handling in ...
Date Tue, 03 Apr 2018 20:20:57 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1504#discussion_r178949774
  
    --- Diff: core/sql/executor/ExExeUtilGet.cpp ---
    @@ -1818,8 +1813,9 @@ short ExExeUtilGetMetadataInfoTcb::work()
     	    {
                    if (!CmpCommon::context()->isAuthorizationEnabled())
                    {
    -                  ComDiagsArea * diags = getDiagsArea();
    -                  *diags << DgSqlCode(-CAT_AUTHORIZATION_NOT_ENABLED);
    +                  ComDiagsArea * diagsArea = getDiagsArea();
    +                  ExRaiseSqlError(getHeap(), &diagsArea, -CAT_AUTHORIZATION_NOT_ENABLED);
    +                  setDiagsArea(diagsArea);
    --- End diff --
    
    I thought about it 3 statements when I made this change. However, there are places where
the diagsArea comes up from the queue entries. 


---

Mime
View raw message