trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] trafodion pull request #1504: [TRAFODION-3009] Streamline error handling in ...
Date Tue, 03 Apr 2018 21:43:11 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1504#discussion_r178971037
  
    --- Diff: core/sql/executor/ExExeUtilGet.cpp ---
    @@ -1818,8 +1813,9 @@ short ExExeUtilGetMetadataInfoTcb::work()
     	    {
                    if (!CmpCommon::context()->isAuthorizationEnabled())
                    {
    -                  ComDiagsArea * diags = getDiagsArea();
    -                  *diags << DgSqlCode(-CAT_AUTHORIZATION_NOT_ENABLED);
    +                  ComDiagsArea * diagsArea = getDiagsArea();
    +                  ExRaiseSqlError(getHeap(), &diagsArea, -CAT_AUTHORIZATION_NOT_ENABLED);
    +                  setDiagsArea(diagsArea);
    --- End diff --
    
    Sorry, I'm not sure I understand. What I am suggesting doesn't require you to change any
other cases, it just makes this case (and the many repetitions of it in your commit) simpler.


---

Mime
View raw message