trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] trafodion pull request #1504: [TRAFODION-3009] Streamline error handling in ...
Date Wed, 04 Apr 2018 20:51:59 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1504#discussion_r179279239
  
    --- Diff: core/sql/executor/ExExeUtilGet.cpp ---
    @@ -1818,8 +1813,9 @@ short ExExeUtilGetMetadataInfoTcb::work()
     	    {
                    if (!CmpCommon::context()->isAuthorizationEnabled())
                    {
    -                  ComDiagsArea * diags = getDiagsArea();
    -                  *diags << DgSqlCode(-CAT_AUTHORIZATION_NOT_ENABLED);
    +                  ComDiagsArea * diagsArea = getDiagsArea();
    +                  ExRaiseSqlError(getHeap(), &diagsArea, -CAT_AUTHORIZATION_NOT_ENABLED);
    +                  setDiagsArea(diagsArea);
    --- End diff --
    
    I misunderstood your comment. I thought that you wanted to make a function. Yes. I am
changing it to pass in diagsArea_ directly, so that we can do this in a single statement.
diagsArea_ already has protected mode access.


---

Mime
View raw message