trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1505: TRAFODION-3019 pstmt.setByte cannot support st...
Date Wed, 04 Apr 2018 22:08:03 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1505#discussion_r179297836
  
    --- Diff: core/conn/jdbc_type2/src/main/java/org/apache/trafodion/jdbc/t2/SQLMXDesc.java
---
    @@ -424,7 +424,7 @@ void checkValidNumericConversion(Locale locale) throws SQLException
         public static final int SQLCHARSETCODE_GB2312           = 17;
     
     	public static final String SQLCHARSETSTRING_UNKNOWN     = "UNKNOWN";
    -	public static final String SQLCHARSETSTRING_ISO88591    = "ISO88591";
    +	public static final String SQLCHARSETSTRING_ISO88591    = "ISO-8859-1";
    --- End diff --
    
    I am curious why this has been changed. In the SQL engine itself, we use "ISO88591". Will
this cause a problem?


---

Mime
View raw message