trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1504: [TRAFODION-3009] Streamline error handling in ...
Date Thu, 05 Apr 2018 17:04:18 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1504#discussion_r179533330
  
    --- Diff: core/sql/sqlcomp/CmpSeabaseDDLschema.cpp ---
    @@ -410,7 +410,8 @@ Int64 schemaUID = getObjectTypeandOwner(&cliInterface,
      if (schemaUID < 0)
        {
           *CmpCommon::diags() << DgSqlCode(-CAT_SCHEMA_DOES_NOT_EXIST_ERROR)
    -                          << DgSchemaName(catalogName + "." + schemaName);
    +                                  << DgString0(catalogName)
    --- End diff --
    
    Consider using DgCatalogName and DgSchemaName instead of DgString0 and DgString1. If we
build a manageability infrastructure that collects event data, it is good for the data to
by typed by token.


---

Mime
View raw message