trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1502: various fixes, details in pull request
Date Thu, 05 Apr 2018 17:51:51 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1502#discussion_r179540660
  
    --- Diff: core/sql/common/NAType.h ---
    @@ -562,7 +562,8 @@ class NAType : public NABasicObject
     				 short displayCaseSpecific = 0);
     
       short getMyTypeAsText(NAString * outputStr, 
    -			NABoolean addNullability = TRUE) const; // output
    +			NABoolean addNullability = TRUE,
    +                        NABoolean addCollation = TRUE) const; // output
    --- End diff --
    
    Looks like the "// output" comment migrated to the wrong place. Maybe it belongs on "NAString
* outputStr"? Or we could just delete it.


---

Mime
View raw message