trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] trafodion pull request #1504: [TRAFODION-3009] Streamline error handling in ...
Date Thu, 05 Apr 2018 17:55:21 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1504#discussion_r179548743
  
    --- Diff: core/sql/bin/SqlciErrors.txt ---
    @@ -2,7 +2,7 @@
     1000 42000 99999 BEGINNER INFRM LOGONLY A syntax error occurred.
     1001 ZZZZZ 99999 ADVANCED CRTCL DIALOUT An internal error occurred in module $0~String0
on line $1~Int0. Details($2~String1).
     1002 ZZZZZ 99999 BEGINNER MAJOR DBADMIN Catalog $0~CatalogName does not exist.
    -1003 ZZZZZ 99999 BEGINNER MINOR DBADMIN Schema $0~SchemaName does not exist.
    +1003 ZZZZZ 99999 BEGINNER MINOR DBADMIN Schema $0~String0.$1~String1 does not exist.
    --- End diff --
    
    There are two ways to raise an error. 
    1) Using ExRaiseSqlError method passing in sqlcode, string and numeric parameters 
    2) concatenating SQLError code and the parameters via ComDiagsArea << DgSqlCode
<< DgStringParam0 or DgCatalogName etc.
    
    Option 1 doesn't support the concept of DgCatalogName or DgSchemaName .
    When an error needs to be populated in both ways, we had to change it to use String0 and
String1 etc..


---

Mime
View raw message