trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] trafodion pull request #1522: [TRAFODION-3009] Streamline error handling in ...
Date Tue, 17 Apr 2018 17:36:47 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1522#discussion_r182166447
  
    --- Diff: core/sql/executor/ExExeUtilCli.cpp ---
    @@ -1119,7 +1119,7 @@ Lng32 ExeCliInterface::executeImmediate(const char * stmtStr,
         {
           // Allocate the diagnostics area if needed
           // and populate the diagnostics conditions
    -      if (*globalDiags == NULL && retcode != 0) {
    +      if (*globalDiags == NULL && retcode != 0 && retcode != 100) {
    --- End diff --
    
    Returning retcode with a value of 100 is ok and should be treated as end of result by
the callers. This additional check just avoids creating a ComDiagsArea if the return code
is just 100.


---

Mime
View raw message