trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1525: [TRAFODION-3028] Support CONTROL QUERY SHAPE (...
Date Thu, 19 Apr 2018 00:13:23 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1525#discussion_r182604451
  
    --- Diff: core/sql/common/ExprNode.cpp ---
    @@ -737,6 +737,16 @@ NABoolean OperatorType::match(OperatorTypeEnum wildcard) const
     	      return FALSE;
     	    }
     
    +        case REL_ANY_EXTRACT:
    +	  switch (op_)
    +	    {
    +	    case REL_FAST_EXTRACT:
    --- End diff --
    
    It's counterintuitive to me that a Hive Insert (or any Insert) is considered an Extract.
"Extract" to me has the connotation of pulling something out, while "Insert" to me has the
connotation of putting something in. Perhaps "Extract" in this context is in reference to
a Trafodion object? But would a Hive Insert always be taking data from a Trafodion object?
Or might we support Insert/Select from one Hive object to another?


---

Mime
View raw message