trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1522: [TRAFODION-3009] Streamline error handling in ...
Date Thu, 19 Apr 2018 00:18:51 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1522#discussion_r182604952
  
    --- Diff: core/sql/executor/ExHdfsScan.cpp ---
    @@ -626,14 +625,23 @@ ExWorkProcRetcode ExHdfsScanTcb::work()
                  else
                     extraBytesRead_ = 0;
                  // headRoom_ is the number of extra bytes to be read (rangeTailIOSize)
    -             // If EOF is reached while reading the range and the extraBytes read
    -             // is less than headRoom_ then process all the data till EOF 
    -             // TODO: If the whole range fits in one buffer, it is need too to process
rows till EOF for the last range alone
    -             // No easy way to identify that last range read, but can identify that it
is not the first range. 
    -             // The rows could be read more than once if there are more than 2 ranges.
    -             // Fix optimizer not to have more than 2 ranges in that case 
    -             if (retArray_[IS_EOF] && extraBytesRead_ < headRoom_ &&
hdfo->getStartOffset() != 0)
    -                extraBytesRead_ = 0;
    +             // If the whole range fits in one buffer, it is needed to process rows till
EOF for the last range alone.
    +/*
    --- End diff --
    
    Is the commented-out code needed anymore? Should we get rid of it?


---

Mime
View raw message