trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1553: [TRAFODION-1861] Run Trafodion on CentOS 7
Date Tue, 08 May 2018 18:45:45 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1553#discussion_r186829077
  
    --- Diff: core/sqf/src/seabed/src/Makefile ---
    @@ -55,6 +55,16 @@ LIBSBUTIL	= $(LIBEXPDIR)/libsbutil.so
     LIBSQSTATESB	= $(LIBEXPDIR)/libsqstatesb.so
     # neet -lrt for clock_gettime
     LIBSX	       += -lrt
    +#
    +# the order of these objects have to be swapped based on the GCC version
    +MS_MPITMSG_O	= $(OUTDIR)/mpitmsg.o \
    +		  $(OUTDIR)/ms.o 
    +ifeq ($(GCC_MAJOR_VERSION_GT_3),1)
    +ifeq ($(GCC_MINOR_VERSION_GT_4),1)
    --- End diff --
    
    I'm not sure this is what you want. For example, if there is ever a gcc version 5.1, the
first "ifeq" will be true but not the second.


---

Mime
View raw message