trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <>
Subject [GitHub] trafodion pull request #1543: [TRAFODION 3047] Cannot get right result using...
Date Wed, 09 May 2018 18:46:39 GMT
Github user DaveBirdsall commented on a diff in the pull request:
    --- Diff: core/sql/optimizer/RelExpr.cpp ---
    @@ -7880,11 +7880,17 @@ NABoolean GroupByAgg::tryToPullUpPredicatesInPreCodeGen(
             pulledPredicates += tempPulledPreds;
    +      // just remove pulled up predicates from char. input
    +      ValueIdSet newInputs(getGroupAttr()->getCharacteristicInputs());
    +      myLocalExpr += selectionPred();
    +      myLocalExpr -= tempPulledPreds;
    +      myLocalExpr.weedOutUnreferenced(newInputs);
    --- End diff --
    Hi Andy. Thanks! I figured out why I could not reproduce the issue. (The issue is that
the parameterized version of the query returns zero rows when it should return one.) There
is another change which I recently merged,,
that either fixes this problem or masks it. I am not sure which yet. If I set CQD COMP_BOOL_158
'OFF', I can now reproduce the problem on the latest code. I'll spend some time playing with
your code change today or tomorrow and evaluate it. Thanks.


View raw message