trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] trafodion pull request #1557: Changes for [TRAFODION-3065] and [TRAFODION-29...
Date Wed, 09 May 2018 19:22:47 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1557#discussion_r187148109
  
    --- Diff: core/sql/executor/ExHdfsScan.cpp ---
    @@ -569,6 +569,7 @@ ExWorkProcRetcode ExHdfsScanTcb::work()
                     break;
                  } 
                  hdfsScan_ = HdfsScan::newInstance((NAHeap *)getHeap(), hdfsScanBuf_, hdfsScanBufMaxSize_,

    +                            hdfsScanTdb().hdfsIoByteArraySize_, 
    --- End diff --
    
    The parameter is a short, but we are passing an unsigned short here, would be better to
make them both a short (see also more comments above about using a 16 bit variable for size
in KB).


---

Mime
View raw message