trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] trafodion pull request #1553: [TRAFODION-1861] Run Trafodion on CentOS 7
Date Thu, 10 May 2018 15:13:04 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1553#discussion_r187361126
  
    --- Diff: core/sqf/src/seabed/src/Makefile ---
    @@ -55,6 +55,16 @@ LIBSBUTIL	= $(LIBEXPDIR)/libsbutil.so
     LIBSQSTATESB	= $(LIBEXPDIR)/libsqstatesb.so
     # neet -lrt for clock_gettime
     LIBSX	       += -lrt
    +#
    +# the order of these objects have to be swapped based on the GCC version
    +MS_MPITMSG_O	= $(OUTDIR)/mpitmsg.o \
    +		  $(OUTDIR)/ms.o 
    +ifeq ($(GCC_MAJOR_VERSION_EQ_4),1)
    +ifeq ($(GCC_MINOR_VERSION_GT_4),1)
    +MS_MPITMSG_O	= $(OUTDIR)/ms.o \
    --- End diff --
    
    If any release above 4.4 should use this order of .sos this change won't work either.
You may consider change it as follows
    By default, the order should be ms.o and mpitmsg.o, 
    Change the order when it is less than 4.4.
    
    



---

Mime
View raw message