trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xiaozhongwang <...@git.apache.org>
Subject [GitHub] trafodion pull request #1562: [TRAFODION-2821] Trafodion core code base need...
Date Sun, 13 May 2018 00:47:15 GMT
Github user xiaozhongwang commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1562#discussion_r187754295
  
    --- Diff: core/sqf/src/tm/tmtransaction.cpp ---
    @@ -797,7 +797,7 @@ short TM_Transaction::status(short *pp_status)
             return iv_last_error;
         }
     
    -    if (!gv_tmlib.is_initialized())
    +    if (!gv_tmlib_initialized)
    --- End diff --
    
    as same as before.
    I understand this code, dirty read before lock, but this is initializing step, performance
is not important, it's hard to maintain.


---

Mime
View raw message