trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] trafodion pull request #1562: [TRAFODION-2821] Trafodion core code base need...
Date Mon, 14 May 2018 05:09:49 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1562#discussion_r187837532
  
    --- Diff: core/sqf/src/tm/tmlib.cpp ---
    @@ -2817,35 +2833,44 @@ void TMLIB::initialize()
         // This call has been changed so that the node count includes spare nodes, so 
         // will give the wrong value for iv_node_count.
         msg_mon_get_node_info(&iv_node_count, MAX_NODES, NULL);
    -    is_initialized(true);
    +    iv_initialized = true;
         // We don't use gv_tmlib_initialized but set it here just to keep things aligned.
         gv_tmlib_initialized = true;
    +    initMutex_->unlock();
    --- End diff --
    
    Trafodion code being legacy code doesn't have exception concept mostly.  The process should
be aborted when there is  exception that would translate into abort. 


---

Mime
View raw message