trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arvind-narain <...@git.apache.org>
Subject [GitHub] trafodion pull request #1534: [TRAFODION-3039] SendEventMsg is used in a wro...
Date Tue, 15 May 2018 01:59:07 GMT
Github user arvind-narain commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1534#discussion_r188146969
  
    --- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp ---
    @@ -6533,6 +6533,8 @@ odbc_SQLSrvr_ExtractLob_sme_(
             if (retcode == SQL_ERROR)
             {
                 ERROR_DESC_def *p_buffer = QryLobExtractSrvrStmt->sqlError.errorList._buffer;
    +            char             errNumStr[128];
    +            sprintf(errNumStr, "%d", p_buffer->sqlcode);
                 strncpy(RequestError, p_buffer->errorText, sizeof(RequestError) - 1);
    --- End diff --
    
    @selvaganesang  since RequestError is initialized at line 6489 and 6585, is there still
a concern?
         char RequestError[200] = {0}; 
    
    @xiaozhongwang if you want you could also take care of line 5254 ? 
    Also do check regarding %d vs.  %ld for sqlcode.
    
    Sorry for the delay in review. Thanks for the change.


---

Mime
View raw message