From codereview-return-6907-apmail-trafodion-codereview-archive=trafodion.apache.org@trafodion.apache.org Tue May 8 18:45:46 2018 Return-Path: X-Original-To: apmail-trafodion-codereview-archive@minotaur.apache.org Delivered-To: apmail-trafodion-codereview-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E85DF18FEF for ; Tue, 8 May 2018 18:45:45 +0000 (UTC) Received: (qmail 84634 invoked by uid 500); 8 May 2018 18:45:45 -0000 Delivered-To: apmail-trafodion-codereview-archive@trafodion.apache.org Received: (qmail 84595 invoked by uid 500); 8 May 2018 18:45:45 -0000 Mailing-List: contact codereview-help@trafodion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: codereview@trafodion.apache.org Delivered-To: mailing list codereview@trafodion.apache.org Received: (qmail 84580 invoked by uid 99); 8 May 2018 18:45:45 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 May 2018 18:45:45 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1CA76E0614; Tue, 8 May 2018 18:45:45 +0000 (UTC) From: DaveBirdsall To: codereview@trafodion.apache.org Reply-To: codereview@trafodion.apache.org References: In-Reply-To: Subject: [GitHub] trafodion pull request #1553: [TRAFODION-1861] Run Trafodion on CentOS 7 Content-Type: text/plain Message-Id: <20180508184545.1CA76E0614@git1-us-west.apache.org> Date: Tue, 8 May 2018 18:45:45 +0000 (UTC) Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1553#discussion_r186829077 --- Diff: core/sqf/src/seabed/src/Makefile --- @@ -55,6 +55,16 @@ LIBSBUTIL = $(LIBEXPDIR)/libsbutil.so LIBSQSTATESB = $(LIBEXPDIR)/libsqstatesb.so # neet -lrt for clock_gettime LIBSX += -lrt +# +# the order of these objects have to be swapped based on the GCC version +MS_MPITMSG_O = $(OUTDIR)/mpitmsg.o \ + $(OUTDIR)/ms.o +ifeq ($(GCC_MAJOR_VERSION_GT_3),1) +ifeq ($(GCC_MINOR_VERSION_GT_4),1) --- End diff -- I'm not sure this is what you want. For example, if there is ever a gcc version 5.1, the first "ifeq" will be true but not the second. ---