trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1622: [TRAFODION-3118] Improve on parts of EXTRACT
Date Mon, 02 Jul 2018 23:53:39 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1622#discussion_r199649960
  
    --- Diff: core/sql/regress/seabase/TEST030 ---
    @@ -98,6 +98,11 @@ select HOUR(interval '5:2:15:36.33' day to second(2)) from (values(1))
as t(a);
     select MINUTE(interval '5:13:25:2.12' day to second(2)) from (values(1)) as t(a);
     select extract (year from INTERVAL '97-02' YEAR TO MONTH) from (values (1)) as t(a);
     select interval '8' year / 4 from dual;
    +select extract(week from date '2005-01-01') from (values(1)) as t(a);
    +select extract(epoch from timestamp '2000-12-30 20:38:40.12') from (values(1)) as t(a);
    +select extract(dow from timestamp '2018-06-21 20:38:40') from (values(1)) as t(a);
    +select extract(doy from timestamp '2018-06-21 20:38:40') from (values(1)) as t(a);
    +select extract(wom from timestamp '2018-06-21 20:38:40') from (values(1)) as t(a);
    --- End diff --
    
    Consider adding tests for the other options, e.g. CENTURY, DECADE


---

Mime
View raw message