trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1633: [TRAFODION-2743] Windows ODBC LOB support
Date Mon, 09 Jul 2018 21:17:24 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1633#discussion_r201149361
  
    --- Diff: win-odbc64/Common/TransportBase.h ---
    @@ -134,6 +134,8 @@ enum SRVR_API {
     	SRVR_API_SQLFASTEXECDIRECT,					//OK WMS
     	SRVR_API_SQLFASTFETCH_PERF,					//OK WMS
     	SRVR_API_GETSEGMENTS,						//OK WMS
    +    SRVR_API_EXTRACTLOB,                        //OK LOB
    +    SRVR_API_UPDATELOB,                         //OK LOB
    --- End diff --
    
    You may want to check the tab settings in your editor; the indentation seems to frequently
be wrong. Best practice is to store spaces instead of tabs.


---

Mime
View raw message