trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1633: [TRAFODION-2743] Windows ODBC LOB support
Date Tue, 10 Jul 2018 18:00:46 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1633#discussion_r201439488
  
    --- Diff: win-odbc64/Common/TransportBase.h ---
    @@ -134,6 +134,8 @@ enum SRVR_API {
     	SRVR_API_SQLFASTEXECDIRECT,					//OK WMS
     	SRVR_API_SQLFASTFETCH_PERF,					//OK WMS
     	SRVR_API_GETSEGMENTS,						//OK WMS
    +    SRVR_API_EXTRACTLOB,                        //OK LOB
    +    SRVR_API_UPDATELOB,                         //OK LOB
    --- End diff --
    
    My guess is that the original code uses tabs (which is bad) and the tab setting in github
assumes 8 spaces per tab. Consider changing your editor to use 8 spaces per tab.


---

Mime
View raw message