trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1645: [TRAFODION-3144] Correct Syntactic Description...
Date Tue, 17 Jul 2018 16:39:35 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1645#discussion_r203094486
  
    --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
    @@ -390,25 +390,27 @@ alter-action is:
     
     column-definition is:
        column-name data-type
    -      ([DEFAULT default]
    -         [[constraint constraint-name] column-constraint])
    +      [[DEFAULT default]
    +         [[constraint constraint-name] column-constraint]]
     
     data-type is:
          char[acter] [(length)[characters]]
    -         [CHARACTER SET char-set-name]
    -         [UPSHIFT] [[not] casespecific]
    -   | char[acter] varying (length)
    -         [character set char-set-name]
    -         [upshift] [[not] casespecific]
    -   | varchar (length) [character set char-set-name]
    -         [upshift] [[not] casespecific]
    -   | varchar2 (length) [character set char-set-name]
    -         [upshift] [[not] casespecific]         
    +                 [CHARACTER SET char-set-name]
    +                 [UPSHIFT] [[NOT] CASESPECIFIC]
    +   | char[acter] varying (length [characters])
    +                         [CHARACTER SET char-set-name]
    +                         [UPSHIFT] [[NOT] CASESPECIFIC]
    +   | varchar (length [characters]) 
    +             [CHARACTER SET char-set-name]
    +             [UPSHIFT] [[NOT] CASESPECIFIC]
    +   | varchar2 (length [characters]) 
    +              [CHARACTER SET char-set-name]
    +              [UPSHIFT] [[NOT] CASESPECIFIC]         
    +   | nchar [length [characters]]
    --- End diff --
    
    Thanks; you are correct. So, it should say, "nchar [(length [characters])]". The length
is optional, but if it is present, parentheses are required.


---

Mime
View raw message