From codereview-return-7274-apmail-trafodion-codereview-archive=trafodion.apache.org@trafodion.apache.org Mon Jul 16 15:45:01 2018 Return-Path: X-Original-To: apmail-trafodion-codereview-archive@minotaur.apache.org Delivered-To: apmail-trafodion-codereview-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9118E189F9 for ; Mon, 16 Jul 2018 15:45:01 +0000 (UTC) Received: (qmail 55267 invoked by uid 500); 16 Jul 2018 15:45:01 -0000 Delivered-To: apmail-trafodion-codereview-archive@trafodion.apache.org Received: (qmail 55232 invoked by uid 500); 16 Jul 2018 15:45:01 -0000 Mailing-List: contact codereview-help@trafodion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: codereview@trafodion.apache.org Delivered-To: mailing list codereview@trafodion.apache.org Received: (qmail 55121 invoked by uid 99); 16 Jul 2018 15:45:00 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Jul 2018 15:45:00 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A3534DFC44; Mon, 16 Jul 2018 15:45:00 +0000 (UTC) From: DaveBirdsall To: codereview@trafodion.apache.org Reply-To: codereview@trafodion.apache.org References: In-Reply-To: Subject: [GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description... Content-Type: text/plain Message-Id: <20180716154500.A3534DFC44@git1-us-west.apache.org> Date: Mon, 16 Jul 2018 15:45:00 +0000 (UTC) Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r202731971 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -3712,6 +3716,60 @@ ATTRIBUTES ALIGNED FORMAT --- SQL operation complete. ``` +* This example demonstrates the character set of NCHAR column (_c1_) *cannot be specified*. --- End diff -- I think one example is probably enough. The point we are trying to make is that "NATIONAL CHAR" implies a particular character set, namely, "UCS2". This is hard-coded into the product; it cannot be changed. Possible word-smith: "NATIONAL CHAR (or NCHAR) is a short-hand for CHAR ... CHARACTER SET UCS2. So it is not possible to specify a CHARACTER SET clause when using NCHAR, as the following example shows:" ---