From codereview-return-7275-apmail-trafodion-codereview-archive=trafodion.apache.org@trafodion.apache.org  Mon Jul 16 15:48:06 2018
Return-Path: <codereview-return-7275-apmail-trafodion-codereview-archive=trafodion.apache.org@trafodion.apache.org>
X-Original-To: apmail-trafodion-codereview-archive@minotaur.apache.org
Delivered-To: apmail-trafodion-codereview-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 6EC1E18A0A
	for <apmail-trafodion-codereview-archive@minotaur.apache.org>; Mon, 16 Jul 2018 15:48:06 +0000 (UTC)
Received: (qmail 58371 invoked by uid 500); 16 Jul 2018 15:48:06 -0000
Delivered-To: apmail-trafodion-codereview-archive@trafodion.apache.org
Received: (qmail 58336 invoked by uid 500); 16 Jul 2018 15:48:06 -0000
Mailing-List: contact codereview-help@trafodion.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:codereview-help@trafodion.apache.org>
List-Unsubscribe: <mailto:codereview-unsubscribe@trafodion.apache.org>
List-Post: <mailto:codereview@trafodion.apache.org>
List-Id: <codereview.trafodion.apache.org>
Reply-To: codereview@trafodion.apache.org
Delivered-To: mailing list codereview@trafodion.apache.org
Received: (qmail 58296 invoked by uid 99); 16 Jul 2018 15:48:05 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Jul 2018 15:48:05 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 9E87BDFC44; Mon, 16 Jul 2018 15:48:05 +0000 (UTC)
From: DaveBirdsall <git@git.apache.org>
To: codereview@trafodion.apache.org
Reply-To: codereview@trafodion.apache.org
References: <git-pr-1645-trafodion@git.apache.org>
In-Reply-To: <git-pr-1645-trafodion@git.apache.org>
Subject: [GitHub] trafodion pull request #1645: [TRAFODION-3144] Correct Syntactic Description...
Content-Type: text/plain
Message-Id: <20180716154805.9E87BDFC44@git1-us-west.apache.org>
Date: Mon, 16 Jul 2018 15:48:05 +0000 (UTC)

Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1645#discussion_r202733241
  
    --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
    @@ -756,6 +758,86 @@ Alter TABLE PRODUCT
     ALTER COLUMN vend_id RENAME TO cstm_id;
     ```
     
    +* This example demonstrates the character set of NCHAR column cannot be altered.
    --- End diff --
    
    See my comments on https://github.com/apache/trafodion/pull/1644. 


---