From codereview-return-7287-apmail-trafodion-codereview-archive=trafodion.apache.org@trafodion.apache.org Tue Jul 17 01:44:37 2018 Return-Path: X-Original-To: apmail-trafodion-codereview-archive@minotaur.apache.org Delivered-To: apmail-trafodion-codereview-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1809218175 for ; Tue, 17 Jul 2018 01:44:37 +0000 (UTC) Received: (qmail 23929 invoked by uid 500); 17 Jul 2018 01:44:37 -0000 Delivered-To: apmail-trafodion-codereview-archive@trafodion.apache.org Received: (qmail 23893 invoked by uid 500); 17 Jul 2018 01:44:37 -0000 Mailing-List: contact codereview-help@trafodion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: codereview@trafodion.apache.org Delivered-To: mailing list codereview@trafodion.apache.org Received: (qmail 23882 invoked by uid 99); 17 Jul 2018 01:44:36 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jul 2018 01:44:36 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 400EFDFC7C; Tue, 17 Jul 2018 01:44:36 +0000 (UTC) From: liuyu000 To: codereview@trafodion.apache.org Reply-To: codereview@trafodion.apache.org References: In-Reply-To: Subject: [GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description... Content-Type: text/plain Message-Id: <20180717014436.400EFDFC7C@git1-us-west.apache.org> Date: Tue, 17 Jul 2018 01:44:36 +0000 (UTC) Github user liuyu000 commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r202873886 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -2963,18 +2963,22 @@ column-definition is: <<< ``` data-type is: - char[acter] [(length [characters])] - [character set char-set-name] - [upshift] [[not]casespecific] + char[acter] [length [characters]] + [character set char-set-name] + [upshift] [[not]casespecific] | char[acter] varying (length [characters]) - [character set char-set-name] - [upshift] [[not]casespecific] - | varchar (length) [character set char-set-name] + [character set char-set-name] + [upshift] [[not]casespecific] + | varchar (length [characters]) + [character set char-set-name] + [upshift] [[not]casespecific] + | varchar2 (length [characters]) + [character set char-set-name] + [upshift] [[not]casespecific] + | nchar [length [characters]] --- End diff -- Same as above. `length [characters]` is optional. ![default](https://user-images.githubusercontent.com/20532956/42792008-e8a9cb4c-89a5-11e8-8066-3a39caa307f3.png) ---