trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PierreSmits <...@git.apache.org>
Subject [GitHub] trafodion pull request #1709: [TRAFODION-3200] correct label and version
Date Mon, 10 Sep 2018 08:00:20 GMT
Github user PierreSmits commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1709#discussion_r216228515
  
    --- Diff: tools/docker/build-base-docker.sh ---
    @@ -19,7 +19,7 @@ set -e -x -u
     
     BASE_SCRIPT_DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )
     
    -export DOCKER_ENV_VERSION="0.1"
    +export DOCKER_ENV_VERSION="2.3"
     export BASE_IMAGE_NAME="trafodion/base:${DOCKER_ENV_VERSION}"
    --- End diff --
    
    For sure the changes need to wind up in the 2.3 branch. 
    
    However, having them also in master will show there what latest stable release should
be worked with when doing a deployment (implementation) in an adopters environment


---

Mime
View raw message