trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hegdean <...@git.apache.org>
Subject [GitHub] trafodion pull request #1761: [TRAFODION-3248]provide more dcscheck option
Date Mon, 17 Dec 2018 18:30:55 GMT
Github user hegdean commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1761#discussion_r242264193
  
    --- Diff: core/sqf/sql/scripts/dcscheck ---
    @@ -171,17 +174,65 @@ if ( [ $sq_stat == 0 ] || [ $sq_stat == 1 ] ); then
        fi
        echo
       fi
    -  echo -e "Process\t\tConfigured\tActual\t\tDown"
    -  echo -e "---------\t----------\t------\t\t----"
    -  echo -e "DcsMaster\t$cfg_dcsmaster_cnt\t\t$actual_dcsmaster_cnt\t\t$down_dcsmaster_cnt"
    -  echo -e "DcsServer\t$cfg_dcsserver_cnt\t\t$actual_dcsserver_cnt\t\t$down_dcsserver_cnt"
    -  echo -e "mxosrvr\t\t$cfg_mxo_cnt\t\t$act_mxo_cnt\t\t$down_mxo_cnt\n"
      else
        echo "DCS is not installed. Please install and configure DCS..."
        exit 1
      fi
     else
      echo "Trafodion is not started or is not operational..."
      echo
    + exit 1
    +fi
    +
    +if [ -z "$OPT_VALUE" ]; then
    +
    +    echo -e "Process\t\tConfigured\tActual\t\tDown"
    --- End diff --
    
    this section can be moved to the default section of the case statement rather than specifically
checking blank OPT_VALUE


---

Mime
View raw message