trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hegdean <...@git.apache.org>
Subject [GitHub] trafodion pull request #1761: [TRAFODION-3248]provide more dcscheck option
Date Mon, 17 Dec 2018 18:33:30 GMT
Github user hegdean commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1761#discussion_r242265112
  
    --- Diff: core/sqf/sql/scripts/dcscheck ---
    @@ -171,17 +174,65 @@ if ( [ $sq_stat == 0 ] || [ $sq_stat == 1 ] ); then
        fi
        echo
       fi
    -  echo -e "Process\t\tConfigured\tActual\t\tDown"
    -  echo -e "---------\t----------\t------\t\t----"
    -  echo -e "DcsMaster\t$cfg_dcsmaster_cnt\t\t$actual_dcsmaster_cnt\t\t$down_dcsmaster_cnt"
    -  echo -e "DcsServer\t$cfg_dcsserver_cnt\t\t$actual_dcsserver_cnt\t\t$down_dcsserver_cnt"
    -  echo -e "mxosrvr\t\t$cfg_mxo_cnt\t\t$act_mxo_cnt\t\t$down_mxo_cnt\n"
      else
        echo "DCS is not installed. Please install and configure DCS..."
        exit 1
      fi
     else
      echo "Trafodion is not started or is not operational..."
      echo
    + exit 1
    +fi
    +
    +if [ -z "$OPT_VALUE" ]; then
    +
    +    echo -e "Process\t\tConfigured\tActual\t\tDown"
    +    echo -e "---------\t----------\t------\t\t----"
    +    echo -e "DcsMaster\t$cfg_dcsmaster_cnt\t\t$actual_dcsmaster_cnt\t\t$down_dcsmaster_cnt"
    +    echo -e "DcsServer\t$cfg_dcsserver_cnt\t\t$actual_dcsserver_cnt\t\t$down_dcsserver_cnt"
    +    echo -e "mxosrvr\t\t$cfg_mxo_cnt\t\t$act_mxo_cnt\t\t$down_mxo_cnt\n"
    +    exit 0
    +else
    + echo
    +    case $OPT_VALUE in
    +        -m)
    +            if [ -e $SQ_PDSH ]; then
    +                STAT_CMD="$SQ_PDSH -w $activeMaster $jstatcmd -gc "
    +            else
    +                STAT_CMD=" $jstatcmd -gc "
    +            fi
    +            J_STATUS=`$STAT_CMD $activeDcsPid `
    +            EC=`echo $J_STATUS | sed -n 1p | awk '{ print $20 }'`
    +            EU=`echo $J_STATUS | sed -n 1p | awk '{ print $21 }'`
    +            OC=`echo $J_STATUS | sed -n 1p | awk '{ print $22 }'`
    +            OU=`echo $J_STATUS | sed -n 1p | awk '{ print $23 }'`
    +            PERCENT_EU=$(echo "scale=2;$EU/$EC "| bc)
    +            PERCENT_OU=$(echo "scale=2;$OU/$OC "| bc)
    +
    +            echo -e "Active DCSMaster VM status:"
    +            echo -e "EC\tEU\tOC\tOU\tPERCENT_EU\tPERCENT_OU\t"
    +            echo -e "$EC\t$EU\t$OC\t$OU\t$PERCENT_EU\t\t$PERCENT_OU\t"
    +            #$STAT_CMD $activeDcsPid
    +            ;;
    +
    +        -t)
    +            if [ -e $SQ_PDSH ]; then
    +                STAT_CMD="$SQ_PDSH -w $activeMaster $jstackcmd "
    --- End diff --
    
    how will this work? pid of the process need to be specified


---

Mime
View raw message