trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] mkby commented on a change in pull request #1802: [TRAFODION-3272] Change installer settings: TRAF_LOG, TRAF_CONF, TRAF_VAR
Date Sat, 02 Mar 2019 14:12:55 GMT
mkby commented on a change in pull request #1802: [TRAFODION-3272] Change installer settings:
TRAF_LOG, TRAF_CONF, TRAF_VAR
URL: https://github.com/apache/trafodion/pull/1802#discussion_r261828329
 
 

 ##########
 File path: install/python-installer/scripts/traf_ldap.py
 ##########
 @@ -34,8 +34,9 @@ def run():
 
     db_root_user = dbcfgs['db_root_user']
     traf_home = os.environ['TRAF_HOME']
+    traf_conf = os.environ['TRAF_CONF']
     sqenv_file = traf_home + '/sqenvcom.sh'
-    traf_auth_config = '%s/sql/scripts/.traf_authentication_config' % traf_home
+    traf_auth_config = '%s/.traf_authentication_config' % traf_conf
 
 Review comment:
   Should we remove the `.` from the ldap config file? Otherwise it will be hided in $TRAF_CONF
dir if not provide `ls -a` command. I'm curious why we hide this config file in the original
design, maybe it's time to change it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message