trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [trafodion] DaveBirdsall commented on issue #1821: [TRAFODION-3291] Fix core when multi-column stats are done on lots of columns
Date Thu, 04 Apr 2019 17:14:56 GMT
DaveBirdsall commented on issue #1821: [TRAFODION-3291] Fix core when multi-column stats are
done on lots of columns
URL: https://github.com/apache/trafodion/pull/1821#issuecomment-479985782
 
 
   @nonstop-qfchen and @sureshsubbiah, could you take another look?
   
   Thank you, @nonstop-qfchen, for the suggestions.
   
   In two places, where sprintf is being used to populate a local buffer, I took your suggestion
and used %.Ns. This is much simpler than the approach I previously used.
   
   Everywhere else, I added new methods to HSLogMan to use an NAString buffer instead of a
fixed length buffer for accumulating log message text. The buffer is populated using C++-style
operator<<. That buffer is cleared when the accumulated text is written to the log.
I checked the QRLogger and underlying CommonLogger code and they appear to support unlimited
message size. So, the new methods in HSLogMan now also support this. This eliminates the problematic
use of sprintf.
   
   For now, the old logging methods and new logging methods will live side-by-side; over time
use of the old methods can be replaced with the new. I believe I've changed all the places
that were needed for long multi-column lists.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message