trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [trafodion] DaveBirdsall commented on a change in pull request #1821: [TRAFODION-3291] Fix core when multi-column stats are done on lots of columns
Date Thu, 04 Apr 2019 21:30:38 GMT
DaveBirdsall commented on a change in pull request #1821: [TRAFODION-3291] Fix core when multi-column
stats are done on lots of columns
URL: https://github.com/apache/trafodion/pull/1821#discussion_r272375471
 
 

 ##########
 File path: core/sql/ustat/hs_log.h
 ##########
 @@ -277,5 +283,8 @@ class HSLogMan
          timeval prevTime_;
          char title_[MAX_TIMING_EVENTS][1000];
          static THREAD_P HSLogMan* instance_;      /* 1 and only 1 instance           */
+
+         // intended as a long-term replacement for msg + Log()
+         NAString logStreamBuffer_;
 
 Review comment:
   Thanks for the review. I'll explore putting logStreamBuffer_ on an NAHeap in a later pull
request. One bit of good news is that this code runs in the tdm_arkcmp process, so we won't
be affecting global heap in mxosrvr.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message