trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [trafodion] selvaganesang opened a new pull request #1858: [TRAFODION-3328] Code cleanup in NADefaults
Date Tue, 01 Oct 2019 14:06:15 GMT
selvaganesang opened a new pull request #1858: [TRAFODION-3328] Code cleanup in NADefaults
   Avoid reading VERSIONS and DEFAULTS table after it is done once in a process.
   This required following cleanup
   1. cqd MODE_SEABASE is removed.
   2. Removed the support to read CQD from a file.
   3. NADefaults constructor now reads the defaults table once and
      saves off the relevant information such as currentDefaults, currentTokens,
      provenances and currentFloats to be reused by the other NADefaults objects.
   4. T2 driver doesn't use the defaultContext to compile any query. Hence, it is not
      possible to use the heap from CmpContext to save off the defaults value.
      The code has been changed the heap from CliGlobals to save the current defaults.
   5. Fixed code to use static literals as it is from the defaultsDefaults to
      avoid invalid memory in the saved defaults
   6. Changes to optimize initialization of currentTokens_ in NADefaults
      CQD * RESET
      Now resets to the defaults when CQD * RESET RESET was issued.
   8. Also optimized initCurrentsFromDefaultsTable further.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message