trafodion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dave Birdsall <dave.birds...@esgyn.com>
Subject RE: Checking up on pull requests
Date Tue, 22 Dec 2015 18:49:46 GMT
Thank you, Qifan.

-----Original Message-----
From: Qifan Chen [mailto:qifan.chen@esgyn.com]
Sent: Tuesday, December 22, 2015 10:35 AM
To: dev <dev@trafodion.incubator.apache.org>
Subject: Re: Checking up on pull requests

I  closed #207 since the content has been merged in already as noted by
Hans, and by verification.

Thanks --Qifan

On Tue, Dec 22, 2015 at 12:27 PM, Selva Govindarajan <
selva.govindarajan@esgyn.com> wrote:

> PR 227 is not yet ready to merge. I have added the comment in the PR
> that I am still working on the final fix.
>
> Selva
>
> -----Original Message-----
> From: Dave Birdsall [mailto:dave.birdsall@esgyn.com]
> Sent: Tuesday, December 22, 2015 10:04 AM
> To: dev@trafodion.incubator.apache.org
> Subject: RE: Checking up on pull requests
>
> This may help:
> https://help.github.com/articles/closing-a-pull-request/
>
> -----Original Message-----
> From: Venkat Muthuswamy [mailto:venkat.muthuswamy@esgyn.com]
> Sent: Tuesday, December 22, 2015 10:00 AM
> To: dev@trafodion.incubator.apache.org
> Subject: RE: Checking up on pull requests
>
> You can close the pull request.
>
> -----Original Message-----
> From: Gunnar Tapper [mailto:tapper.gunnar@gmail.com]
> Sent: Tuesday, December 22, 2015 9:59 AM
> To: dev@trafodion.incubator.apache.org
> Subject: Re: Checking up on pull requests
>
> How does one cancel a pull request?
>
> On Tue, Dec 22, 2015 at 10:43 AM, Dave Birdsall
> <dave.birdsall@esgyn.com>
> wrote:
>
> > That sounds prudent to me.
> >
> > -----Original Message-----
> > From: Gunnar Tapper [mailto:tapper.gunnar@gmail.com]
> > Sent: Tuesday, December 22, 2015 9:41 AM
> > To: dev@trafodion.incubator.apache.org
> > Subject: Re: Checking up on pull requests
> >
> > Hi,
> >
> > 235 should have changes to the docs directory only. I rebased
> > yesterday moving in the files I had changed. Maybe it's best to
> > cancel
> > 235 and retry?
> >
> > Gunnar
> >
> > On Tue, Dec 22, 2015 at 10:00 AM, Dave Birdsall
> > <dave.birdsall@esgyn.com>
> > wrote:
> >
> > > Hi,
> > >
> > >
> > >
> > > We seem to be getting an increasing queue of pull requests
> > > https://github.com/apache/incubator-trafodion/pulls. (And I’m
> > > partly at fault for keeping one stale request out there.)
> > >
> > >
> > >
> > > Just wanted to survey the ones that are outstanding and see if we
> > > can move some of them along.
> > >
> > >
> > >
> > > https://github.com/apache/incubator-trafodion/pull/96 -- This one
> > > was first opened on Sept. 30, had a lot of activity through
> > > October, but little since. Never passed the tests. It now has
> > > conflicts that have to be resolved before merging. Should this one
> > > be closed and resubmitted?
> > >
> > >
> > >
> > > https://github.com/apache/incubator-trafodion/pull/174 -- This one
> > > is mine; it should not be merged. I need to rework it. Other
> > > priorities have gotten in the way.
> > >
> > >
> > >
> > > https://github.com/apache/incubator-trafodion/pull/177 -- I gather
> > > this one is awaiting YCSB test results.
> > >
> > >
> > >
> > > https://github.com/apache/incubator-trafodion/pull/203 -- This one
> > > has been quite active, but it seems to be failing the static
> > > checks tests.
> > >
> > >
> > >
> > > https://github.com/apache/incubator-trafodion/pull/207 -- This one
> > > has a question in it, asking if it should be abandoned. Qifan,
> > > could you please take a look?
> > >
> > >
> > >
> > > https://github.com/apache/incubator-trafodion/pull/227 -- This one
> > > has been reworked, and has passed tests. I think all it is waiting
> > > for is re-review by folks who commented earlier. Perhaps it is
> > > ready for commit? Hans, could you take a look?
> > >
> > >
> > >
> > > https://github.com/apache/incubator-trafodion/pull/233 -- This one
> > > has received positive reviews; it just needs to pass the tests.
> > > The testing infrastructure was a bit flaky yesterday, so it is
> > > undergoing retests now.
> > >
> > >
> > >
> > > https://github.com/apache/incubator-trafodion/pull/235 -- Gunnar
> > > has some concerns about this particular request; it might have
> > > picked up stuff he didn’t desire. It shows now that it has
> > > conflicts that need resolving so it can’t be merged in its present
> > > state. Review might
> help.
> > >
> > >
> > >
> > > https://github.com/apache/incubator-trafodion/pull/236 -- This one
> > > looks like it is almost ready. There is a question about whether
> > > regression tests have been added that needs to be answered.
> > >
> > >
> > >
> > > https://github.com/apache/incubator-trafodion/pull/237 -- This one
> > > has passed tests and just needs someone to review it. Someone who
> > > has a grasp on provenance would be good.
> > >
> > >
> > >
> > > https://github.com/apache/incubator-trafodion/pull/239 -- This one
> > > is being retested (yesterday the testing infrastructure was flaky).
> > > It also needs someone to review and bless it.
> > >
> > >
> > >
> > > Thanks,
> > >
> > >
> > >
> > > Dave
> > >
> >
> >
> >
> > --
> > Thanks,
> >
> > Gunnar
> > *If you think you can you can, if you think you can't you're right.*
> >
>
>
>
> --
> Thanks,
>
> Gunnar
> *If you think you can you can, if you think you can't you're right.*
>



--
Regards, --Qifan

Mime
View raw message