trafodion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pierre Smits <pierre.sm...@gmail.com>
Subject Re: RAT, how is it done ? [was Re: [VOTE] Graduate from Incubator and become a top-level project]
Date Sun, 19 Nov 2017 08:28:07 GMT
Hi Jacques, All,

Can you elaborate on why this needs to be done 'before graduation'?

Best regards,

Pierre Smits

ORRTIZ.COM <http://www.orrtiz.com>
OFBiz based solutions & services

OEM - The OFBiz Extensions Marketplace1
http://oem.ofbizci.net/oci-2/
1 not affiliated to (and not endorsed by) the OFBiz project

On Sat, Nov 18, 2017 at 1:04 PM, Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:

> Hi All,
>
> I found only that, but we need to take care of them before graduating:
>
> Files with unapproved licenses:
>   C:/projectsASF/incubator-trafodion/rat.out
> C:/projectsASF/incubator-trafodion/core/conn/unixodbc/odbc/
> odbcclient/unixcli/security_dll
> C:/projectsASF/incubator-trafodion/core/sqf/src/seatrans/tm/
> hbasetmlib2/src/main/java/org/trafodion/sql/TrafConfiguration.java
> C:/projectsASF/incubator-trafodion/core/sql/SqlCompilerDebug
> ger/Resource/Main/A.bmp
> C:/projectsASF/incubator-trafodion/core/sql/SqlCompilerDebug
> ger/Resource/Main/C.bmp
> C:/projectsASF/incubator-trafodion/core/sql/SqlCompilerDebug
> ger/Resource/Main/G.bmp
> C:/projectsASF/incubator-trafodion/core/sql/SqlCompilerDebug
> ger/Resource/Main/I.bmp
> C:/projectsASF/incubator-trafodion/core/sql/SqlCompilerDebug
> ger/Resource/Main/J.bmp
> C:/projectsASF/incubator-trafodion/core/sql/SqlCompilerDebug
> ger/Resource/Main/L.bmp
> C:/projectsASF/incubator-trafodion/core/sql/SqlCompilerDebug
> ger/Resource/Main/N.bmp
> C:/projectsASF/incubator-trafodion/core/sql/SqlCompilerDebug
> ger/Resource/Main/O.bmp
> C:/projectsASF/incubator-trafodion/core/sql/SqlCompilerDebug
> ger/Resource/Main/P.bmp
> C:/projectsASF/incubator-trafodion/core/sql/SqlCompilerDebug
> ger/Resource/Main/Q.bmp
> C:/projectsASF/incubator-trafodion/core/sql/SqlCompilerDebug
> ger/Resource/Main/T.bmp
> C:/projectsASF/incubator-trafodion/core/sql/SqlCompilerDebug
> ger/Resource/Main/W.bmp
> C:/projectsASF/incubator-trafodion/core/sql/SqlCompilerDebug
> ger/Resource/Main/X.bmp
> C:/projectsASF/incubator-trafodion/win-odbc64/Install/SetCer
> tificateDirReg/SetCertificateDirReg/dialog.bmp
>
> I quickly tried to change using the same syntax than in OFBiz
> https://svn.apache.org/repos/asf/ofbiz/tools/rat-excludes.txt which is
> used by Builbot
>
> But it seems the syntax is different when Rat is run locally (and in
> Jenkins?). Maybe I overlooked something, please ignore...
>
> Anyway, I have finally found the right syntax and committed. Please check
> for files location in the list.
>
> Thanks
>
> Jacques
>
>
>
> Le 18/11/2017 à 11:22, Jacques Le Roux a écrit :
>
>> Thanks Sandhya,
>>
>> Quite clear, I'll check on my side. Seems that things are already quite
>> well ready for graduation indeed :)
>>
>> Jacques
>>
>>
>> Le 17/11/2017 à 16:58, Sandhya Sundaresan a écrit :
>>
>>> I'm not sure if the log output is actually saved each time. Steve may be
>>> able to add to that question. There is  a "RAT check" that's done (see
>>> below for an example pull request log output ):
>>> The check just ensures there are 0 files flaged by the RAT tool .
>>> At the root level of the trafodion tree, you will find a RAT_README file
>>> that contains all the excluded files and why they are excluded  and also
>>> how to run RAT with the  Trafodion source tree.
>>> -rw-rw-r--. 1 sandhyasun sandhyasun 9769 Apr 20  2017 RAT_README
>>>
>>> 2017-11-17 11:45:18 Triggered by: https://github.com/apache/incu
>>> bator-trafodion/pull/1303
>>> 2017-11-17 11:45:18 Using reference: origin/pr/1303/merge
>>> 2017-11-17 11:45:18 Building for pull request PRID-commitID:
>>> PR1303-e385ae3e1eba81069dae62d750cf1810dbb29d69
>>> 2017-11-17 11:45:18 Saving output to Git-Prep.log
>>> 2017-11-17 11:45:18 + exec
>>> 2017-11-17 11:45:36 [workspace] $ /bin/sh -xe
>>> /tmp/hudson1682655249198384046.sh
>>> 2017-11-17 11:45:36 + /usr/local/bin/binary-file-check.sh trafodion
>>> 2017-11-17 11:45:36 ==============================
>>> ==========================
>>> 2017-11-17 11:45:36 ==============================
>>> ==========================
>>> 2017-11-17 11:45:36 === Fri Nov 17 11:45:36 UTC 2017:
>>> /usr/local/bin/binary-file-check.sh
>>> 2017-11-17 11:45:36 ===
>>> 2017-11-17 11:45:36 ==============================
>>> ==========================
>>> 2017-11-17 11:45:36 File list command: git diff --pretty=format:%n
>>> --name-status origin/master origin/pr/1303/merge
>>> 2017-11-17 11:45:36 'file' command reports:
>>> 2017-11-17 11:45:36 dcs/src/main/java/org/trafodion/dcs/Constants.java
>>> : ASCII text
>>> 2017-11-17 11:45:36 [workspace] $ /bin/sh -xe
>>> /tmp/hudson6432119697959151311.sh
>>> 2017-11-17 11:45:36 + /usr/local/bin/find-bad-source.sh -d trafodion
>>> 2017-11-17 11:45:36 ==============================
>>> ==========================
>>> 2017-11-17 11:45:36 ==============================
>>> ==========================
>>> 2017-11-17 11:45:36 === Fri Nov 17 11:45:36 UTC 2017:
>>> /usr/local/bin/find-bad-source.sh
>>> 2017-11-17 11:45:36 ===
>>> 2017-11-17 11:45:36 ==============================
>>> ==========================
>>> 2017-11-17 11:45:36 File list command: git diff --pretty=format:%n
>>> --name-status origin/master origin/pr/1303/merge
>>> 2017-11-17 11:45:36 Number of files to examine = 1
>>> 2017-11-17 11:45:36 Files to examine:
>>> 2017-11-17 11:45:36 dcs/src/main/java/org/trafodion/dcs/Constants.java
>>> 2017-11-17 11:45:36
>>> 2017-11-17 11:45:36 Search command: egrep -rnH
>>> -e'<<<<<<<.*HEAD|>>>>>>>>.*HEAD'
>>> 2017-11-17 11:45:36
>>> 2017-11-17 11:45:36 Success! Found no bad lines.
>>> 2017-11-17 11:45:36 [workspace] $ /bin/sh -xe
>>> /tmp/hudson1912072329055066007.sh
>>> 2017-11-17 11:45:36 + /usr/local/bin/rat-check.sh
>>> 2017-11-17 11:45:36 ==============================
>>> ==========================
>>> 2017-11-17 11:45:36 Removing build-version.txt
>>> 2017-11-17 11:45:39 Success! Found no license issues.
>>>
>>>
>>> -----Original Message-----
>>> From: Jacques Le Roux [mailto:jacques.le.roux@les7arts.com]
>>> Sent: Friday, November 17, 2017 7:11 AM
>>> To: dev@trafodion.incubator.apache.org
>>> Subject: Re: RAT, how is it done ? [was Re: [VOTE] Graduate from
>>> Incubator and become a top-level project]
>>>
>>> Thanks Sandhya,
>>>
>>> Do you know where I can see the result?
>>>
>>> Jacques
>>>
>>>
>>> Le 17/11/2017 à 16:04, Sandhya Sundaresan a écrit :
>>>
>>>> Hi Jacques,
>>>>         It can be run manually. But we also have it running every night
>>>> as part of our automated build process. So in case anyone adds a file with
>>>> an incorrect or missing license the RAT tool that 's run as part of the
>>>> build , it will fail the build and not allow them to commit.
>>>> Sandhya
>>>>
>>>> -----Original Message-----
>>>> From: Liu, Ming (Ming) [mailto:ming.liu@esgyn.cn]
>>>> Sent: Friday, November 17, 2017 6:16 AM
>>>> To: Jacques Le Roux <jacques.le.roux@les7arts.com<mailto:
>>>> jacques.le.roux@les7arts.com>>;
>>>> dev@trafodion.incubator.apache.org<mailto:dev@trafodion.
>>>> incubator.apache.org>
>>>> Subject: RE: RAT, how is it done ? [was Re: [VOTE] Graduate from
>>>> Incubator and become a top-level project]
>>>>
>>>> Yes Jacques, it is done manually.
>>>>
>>>> Ming
>>>>
>>>> -----Original Message-----
>>>> From: Jacques Le Roux [mailto:jacques.le.roux@les7arts.com]
>>>> Sent: Friday, November 17, 2017 6:33 PM
>>>> To: dev@trafodion.incubator.apache.org<mailto:dev@trafodion.
>>>> incubator.apache.org>; Liu, Ming (Ming)
>>>> <ming.liu@esgyn.cn<mailto:ming.liu@esgyn.cn>>
>>>> Subject: RAT, how is it done ? [was Re: [VOTE] Graduate from Incubator
>>>> and become a top-level project]
>>>>
>>>> Thanks Ming,
>>>>
>>>> So you mean it's done manually then?
>>>>
>>>> And sorry All, for hijacking the vote thread :-[
>>>>
>>>> Jacques
>>>>
>>>>
>>>> Le 17/11/2017 à 09:26, Liu, Ming (Ming) a écrit :
>>>>
>>>>> Hi, Jacques,
>>>>>
>>>>> As part of R2.2 release process, RAT check is passed.
>>>>>
>>>>> Thanks,
>>>>> Ming
>>>>>
>>>>> -----Original Message-----
>>>>> From: Jacques Le Roux [mailto:jacques.le.roux@les7arts.com]
>>>>> Sent: Friday, November 17, 2017 4:24 PM
>>>>> To: dev@trafodion.incubator.apache.org<mailto:dev@trafodion.
>>>>> incubator.apache.org>
>>>>> Subject: Re: [VOTE] Graduate from Incubator and become a top-level
>>>>> project
>>>>>
>>>>> Ah something I forgot to ask. Are you running a RAT check
>>>>> https://creadur.apache.org/rat/ ?
>>>>>
>>>>> Thanks
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>> Le 16/11/2017 à 19:21, Jacques Le Roux a écrit :
>>>>>
>>>>>> Though I did not get a chance yet to completely test the last
>>>>>> release, after looking at the documentation I'm confident the
>>>>>> project is ready to graduate
>>>>>>
>>>>>> +1
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>>
>>>>>> Le 16/11/2017 à 17:21, Pierre Smits a écrit :
>>>>>>
>>>>>>> Hi all,
>>>>>>>
>>>>>>> Following upon our [DISCUSSION] Graduation of The (incubating)
>>>>>>> Apache Trafodion Project
>>>>>>> <https://lists.apache.org/thread.html/8e00251a72a5e3f667fbcfc319c02
>>>>>>> 1 3ad86ff21839e98e0ae68520e3@%3Cdev.trafodion.apache.org%3E<mailto:
>>>>>>> 3ad86ff21839e98e0ae68520e3@%3Cdev.trafodion.apache.org%3E>>
>>>>>>>
>>>>>>> I herby propose that we graduate from incubating and have our
>>>>>>> Apache Trafodion Project established as an independent (and
>>>>>>> top-level ASF) project. According to The Graduation Process
>>>>>>> <https://incubator.apache.org/guides/graduation.html#the_graduation
>>>>>>> _
>>>>>>> process> a vote is not required, but votes provided shows
that the
>>>>>>> project is ready to embark on the next phase in its lifecycle.
So
>>>>>>> please all come forward and express your vote.
>>>>>>>
>>>>>>> Votes from our Mentors (Jacques, Michael) will count as binding
>>>>>>> votes.
>>>>>>>
>>>>>>> Vote options are:
>>>>>>> +1 - meaning: Yes, I want the project to graduate
>>>>>>> -1 - meaning: No, I don't want the project to graduate
>>>>>>> +0 - meaning: Abstain
>>>>>>>
>>>>>>> A normal majority (50% of the number of voters+ 1 vote) will
be
>>>>>>> applicable.
>>>>>>>
>>>>>>>
>>>>>>> Here is my vote: +1
>>>>>>>
>>>>>>> Best regards,
>>>>>>>
>>>>>>>
>>>>>>> Pierre Smits
>>>>>>>
>>>>>>> ORRTIZ.COM <http://www.orrtiz.com>
>>>>>>> OFBiz based solutions & services
>>>>>>>
>>>>>>> OEM - The OFBiz Extensions Marketplace1
>>>>>>> http://oem.ofbizci.net/oci-2/
>>>>>>> 1 not affiliated to (and not endorsed by) the OFBiz project
>>>>>>>
>>>>>>>
>>>
>>
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message