training-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dpav...@apache.org
Subject [incubator-training] branch master updated: Add Review Options for Contribution (#56)
Date Mon, 21 Oct 2019 19:53:55 GMT
This is an automated email from the ASF dual-hosted git repository.

dpavlov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-training.git


The following commit(s) were added to refs/heads/master by this push:
     new c660305  Add Review Options for Contribution (#56)
c660305 is described below

commit c660305163cf8f37ff444c2142a0a8781a20d6c0
Author: Gautam Gupta <greatgautam@gmail.com>
AuthorDate: Mon Oct 21 12:53:49 2019 -0700

    Add Review Options for Contribution (#56)
---
 site/src/site/asciidoc/developers/contributing.adoc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/site/src/site/asciidoc/developers/contributing.adoc b/site/src/site/asciidoc/developers/contributing.adoc
index 16e629a..f8a0065 100644
--- a/site/src/site/asciidoc/developers/contributing.adoc
+++ b/site/src/site/asciidoc/developers/contributing.adoc
@@ -54,7 +54,9 @@ However as with all other things, please do reach out to us on the mailing
list
 - https://lab.github.com/[Github Learning Lab]
 
 ==== Review Process
-The Training project follows a review-then-commit workflow, which basically means that no
commit should be made to the repository that has not been reviewed and approved by the required
number of persons.
+The Training project follows a review-then-commit (RTC) workflow for core modules such as
the presentation framework, themes and stuff used by presentations, and a commit-then-review
(CTR) model for content modules. 
+
+Review-then-commit means that no commit should be made to the repository that has not been
reviewed and approved by the required number of persons. Where as, commit-then-review model
allows for faster and simpler contribution of content to training project. CTR also applies
if no one objects to a PR for first 72 hours.
 
 For reviews we distinguish between _content_ commits that add content to training decks and
_functional_ commits like code changes to tools or similar things.
 


Mime
View raw message