tuscany-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsdelf...@apache.org
Subject svn commit: r567543 - in /incubator/tuscany/java/sca/demos: alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/ alert-aggregator/src/test/java/org/apache/tuscany/sca/demos/aggregator/ bigbank-account/src/main/java/bigbank/account/fe...
Date Mon, 20 Aug 2007 05:17:28 GMT
Author: jsdelfino
Date: Sun Aug 19 22:17:26 2007
New Revision: 567543

URL: http://svn.apache.org/viewvc?rev=567543&view=rev
Log:
Code cleanup, fixed warnings, removed unused imports, variables and dead code, added missing
annotations.

Modified:
    incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/AlertTypeNonSDOImpl.java
    incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/AlertsService.java
    incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/AlertsTypeNonSDOImpl.java
    incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/ConfigTypeNonSDOImpl.java
    incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/SourceTypeNonSDOImpl.java
    incubator/tuscany/java/sca/demos/alert-aggregator/src/test/java/org/apache/tuscany/sca/demos/aggregator/AlertsTestCase.java
    incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/account/feed/AccountFeedImpl.java
    incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/accountdata/CheckingAccount.java
    incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/accountdata/SavingsAccount.java
    incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/accountdata/StockAccount.java
    incubator/tuscany/java/sca/demos/bigbank-account/src/test/java/test/BigBankTestCase.java
    incubator/tuscany/java/sca/demos/mortgage-loanapproval/src/main/java/mortgage/Customer.java
    incubator/tuscany/java/sca/demos/mortgage-loanapproval/src/test/java/mortgage/MortgageClientTestCase.java

Modified: incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/AlertTypeNonSDOImpl.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/AlertTypeNonSDOImpl.java?rev=567543&r1=567542&r2=567543&view=diff
==============================================================================
--- incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/AlertTypeNonSDOImpl.java
(original)
+++ incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/AlertTypeNonSDOImpl.java
Sun Aug 19 22:17:26 2007
@@ -23,8 +23,9 @@
  
 public class AlertTypeNonSDOImpl implements AlertType
 {
+    private static final long serialVersionUID = 670364038865656196L;
 
-  /**
+/**
    * The default value of the '{@link #getTitle() <em>Title</em>}' attribute.
    * <!-- begin-user-doc -->
    * <!-- end-user-doc -->
@@ -313,6 +314,7 @@
    * <!-- end-user-doc -->
    * @generated
    */
+  @Override
   public String toString()
   {
     StringBuffer result = new StringBuffer(super.toString());

Modified: incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/AlertsService.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/AlertsService.java?rev=567543&r1=567542&r2=567543&view=diff
==============================================================================
--- incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/AlertsService.java
(original)
+++ incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/AlertsService.java
Sun Aug 19 22:17:26 2007
@@ -20,8 +20,6 @@
 package org.apache.tuscany.sca.demos.aggregator;
 
 import org.apache.tuscany.sca.demos.aggregator.types.AlertsType;
-import org.apache.tuscany.sca.demos.aggregator.types.ConfigType;
-
 import org.osoa.sca.annotations.Remotable;
 import org.osoa.sca.annotations.Service;
 

Modified: incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/AlertsTypeNonSDOImpl.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/AlertsTypeNonSDOImpl.java?rev=567543&r1=567542&r2=567543&view=diff
==============================================================================
--- incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/AlertsTypeNonSDOImpl.java
(original)
+++ incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/AlertsTypeNonSDOImpl.java
Sun Aug 19 22:17:26 2007
@@ -38,8 +38,9 @@
  */
 public class AlertsTypeNonSDOImpl implements AlertsType
 {
-
-  /**
+    private static final long serialVersionUID = -3784576466148158776L;
+    
+/**
    * The cached value of the '{@link #getAlert() <em>Alert</em>}' containment
reference list.
    * <!-- begin-user-doc -->
    * <!-- end-user-doc -->

Modified: incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/ConfigTypeNonSDOImpl.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/ConfigTypeNonSDOImpl.java?rev=567543&r1=567542&r2=567543&view=diff
==============================================================================
--- incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/ConfigTypeNonSDOImpl.java
(original)
+++ incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/ConfigTypeNonSDOImpl.java
Sun Aug 19 22:17:26 2007
@@ -26,8 +26,9 @@
 
 public class ConfigTypeNonSDOImpl implements ConfigType
 {
-  
-  protected List source = new ArrayList();
+    private static final long serialVersionUID = 2522843951360675364L;
+    
+    protected List source = new ArrayList();
   
   /**
    * <!-- begin-user-doc -->

Modified: incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/SourceTypeNonSDOImpl.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/SourceTypeNonSDOImpl.java?rev=567543&r1=567542&r2=567543&view=diff
==============================================================================
--- incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/SourceTypeNonSDOImpl.java
(original)
+++ incubator/tuscany/java/sca/demos/alert-aggregator/src/main/java/org/apache/tuscany/sca/demos/aggregator/SourceTypeNonSDOImpl.java
Sun Aug 19 22:17:26 2007
@@ -18,17 +18,14 @@
  */
 package org.apache.tuscany.sca.demos.aggregator;
 
-import commonj.sdo.Sequence;
-import commonj.sdo.Type;
-
 import org.apache.tuscany.sca.demos.aggregator.types.SourceType;
-import org.apache.tuscany.sca.demos.aggregator.types.TypesFactory;
 
-import org.apache.tuscany.sdo.impl.DataObjectBase;
+import commonj.sdo.Sequence;
 
 
 public class SourceTypeNonSDOImpl implements SourceType
 {
+  private static final long serialVersionUID = -4986294578888767793L;
 
   public final static int NAME = 0;
 

Modified: incubator/tuscany/java/sca/demos/alert-aggregator/src/test/java/org/apache/tuscany/sca/demos/aggregator/AlertsTestCase.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/demos/alert-aggregator/src/test/java/org/apache/tuscany/sca/demos/aggregator/AlertsTestCase.java?rev=567543&r1=567542&r2=567543&view=diff
==============================================================================
--- incubator/tuscany/java/sca/demos/alert-aggregator/src/test/java/org/apache/tuscany/sca/demos/aggregator/AlertsTestCase.java
(original)
+++ incubator/tuscany/java/sca/demos/alert-aggregator/src/test/java/org/apache/tuscany/sca/demos/aggregator/AlertsTestCase.java
Sun Aug 19 22:17:26 2007
@@ -39,6 +39,7 @@
     /**
      * Runs before each test method
      */
+    @Override
     protected void setUp() throws Exception {
         scaDomain = SCADomain.newInstance("alerts.composite");
         super.setUp();
@@ -47,6 +48,7 @@
     /**
      * Runs after each test method
      */
+    @Override
     protected void tearDown() {
         scaDomain.close();
     }
@@ -62,13 +64,15 @@
     public void testGetAllNewAlerts() throws Exception {   
         JSONObject jsonRequest = new JSONObject("{\"params\":[\"sometext\"],\"method\":\"getAllNewAlerts\",\"id\":2}");
         JSONObject jsonResp    = callService ("http://localhost:8080/AlertsServiceJSONRPC",
-                                              jsonRequest);                             
    
+                                              jsonRequest);
+        assertNotNull(jsonResp);
     }   
     
     public void testAddAlertSources() throws Exception {   
         JSONObject jsonRequest = new JSONObject("{\"params\":[{\"name\":\"news\",\"id\":\"2\",\"address\":\"www.news.com\",\"feedAddress\":\"http://news.com.com/2547-1_3-0-20.xml\",\"feedType\":\"rss\",\"lastChecked\":\"lastChecked\",\"javaClass\":\"org.apache.tuscany.sca.demos.aggregator.types.impl.SourceTypeImpl\"}],\"method\":\"addAlertSource\",\"id\":2}");
         JSONObject jsonResp    = callService ("http://localhost:8080/AlertsSourcesServiceJSONRPC",
                                               jsonRequest);  
+        assertNotNull(jsonResp);
     }
   
     public void testGetAlertSources() throws Exception {  

Modified: incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/account/feed/AccountFeedImpl.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/account/feed/AccountFeedImpl.java?rev=567543&r1=567542&r2=567543&view=diff
==============================================================================
--- incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/account/feed/AccountFeedImpl.java
(original)
+++ incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/account/feed/AccountFeedImpl.java
Sun Aug 19 22:17:26 2007
@@ -18,11 +18,9 @@
  */
 package bigbank.account.feed;
 
-import java.io.InputStream;
 import java.util.Collections;
 
 import org.apache.tuscany.sca.binding.feed.collection.Collection;
-import org.apache.tuscany.sca.binding.feed.collection.NotFoundException;
 import org.osoa.sca.annotations.Reference;
 import org.osoa.sca.annotations.Service;
 

Modified: incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/accountdata/CheckingAccount.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/accountdata/CheckingAccount.java?rev=567543&r1=567542&r2=567543&view=diff
==============================================================================
--- incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/accountdata/CheckingAccount.java
(original)
+++ incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/accountdata/CheckingAccount.java
Sun Aug 19 22:17:26 2007
@@ -43,6 +43,7 @@
         this.balance = b;
     }
 
+    @Override
     public String toString() {
         return accountNumber + ", balance:" + balance;
     }

Modified: incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/accountdata/SavingsAccount.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/accountdata/SavingsAccount.java?rev=567543&r1=567542&r2=567543&view=diff
==============================================================================
--- incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/accountdata/SavingsAccount.java
(original)
+++ incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/accountdata/SavingsAccount.java
Sun Aug 19 22:17:26 2007
@@ -43,6 +43,7 @@
         this.balance = b;
     }
 
+    @Override
     public String toString() {
         return accountNumber + ", balance:" + balance;
     }

Modified: incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/accountdata/StockAccount.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/accountdata/StockAccount.java?rev=567543&r1=567542&r2=567543&view=diff
==============================================================================
--- incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/accountdata/StockAccount.java
(original)
+++ incubator/tuscany/java/sca/demos/bigbank-account/src/main/java/bigbank/accountdata/StockAccount.java
Sun Aug 19 22:17:26 2007
@@ -52,6 +52,7 @@
         this.symbol = s;
     }
 
+    @Override
     public String toString() {
         return accountNumber + ", symbol:" + symbol + ", quantity:" + quantity;
     }

Modified: incubator/tuscany/java/sca/demos/bigbank-account/src/test/java/test/BigBankTestCase.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/demos/bigbank-account/src/test/java/test/BigBankTestCase.java?rev=567543&r1=567542&r2=567543&view=diff
==============================================================================
--- incubator/tuscany/java/sca/demos/bigbank-account/src/test/java/test/BigBankTestCase.java
(original)
+++ incubator/tuscany/java/sca/demos/bigbank-account/src/test/java/test/BigBankTestCase.java
Sun Aug 19 22:17:26 2007
@@ -27,12 +27,6 @@
  */
 public class BigBankTestCase extends TestCase {
 
-    protected void setUp() throws Exception {
-    }
-
-    protected void tearDown() throws Exception {
-    }
-
     public void testServer() throws Exception {
         BigBankServer.main(new String[] {"1000"});
     }

Modified: incubator/tuscany/java/sca/demos/mortgage-loanapproval/src/main/java/mortgage/Customer.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/demos/mortgage-loanapproval/src/main/java/mortgage/Customer.java?rev=567543&r1=567542&r2=567543&view=diff
==============================================================================
--- incubator/tuscany/java/sca/demos/mortgage-loanapproval/src/main/java/mortgage/Customer.java
(original)
+++ incubator/tuscany/java/sca/demos/mortgage-loanapproval/src/main/java/mortgage/Customer.java
Sun Aug 19 22:17:26 2007
@@ -69,6 +69,7 @@
         this.ssn = ssn;
     }
 
+    @Override
     public String toString() {
         return firstName + " " + lastName + "[" + ssn + "]";
     }

Modified: incubator/tuscany/java/sca/demos/mortgage-loanapproval/src/test/java/mortgage/MortgageClientTestCase.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/demos/mortgage-loanapproval/src/test/java/mortgage/MortgageClientTestCase.java?rev=567543&r1=567542&r2=567543&view=diff
==============================================================================
--- incubator/tuscany/java/sca/demos/mortgage-loanapproval/src/test/java/mortgage/MortgageClientTestCase.java
(original)
+++ incubator/tuscany/java/sca/demos/mortgage-loanapproval/src/test/java/mortgage/MortgageClientTestCase.java
Sun Aug 19 22:17:26 2007
@@ -29,6 +29,7 @@
     private SCADomain domain;
     private LoanApproval loanApproval;
 
+    @Override
     protected void setUp() throws Exception {
         domain = SCADomain.newInstance("Mortgage.composite");
         loanApproval = domain.getService(LoanApproval.class, "LoanApprovalComponent");



---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org


Mime
View raw message