tuscany-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mcombell...@apache.org
Subject svn commit: r658208 - /incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeIncludeBuilderImpl.java
Date Tue, 20 May 2008 11:21:59 GMT
Author: mcombellack
Date: Tue May 20 04:21:58 2008
New Revision: 658208

URL: http://svn.apache.org/viewvc?rev=658208&view=rev
Log:
Removed cast of Composite to PolicySetAttachPoint as it is not needed since Composite extends
PolicySetAttachPoint (FindBugs reported issue)

Modified:
    incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeIncludeBuilderImpl.java

Modified: incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeIncludeBuilderImpl.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeIncludeBuilderImpl.java?rev=658208&r1=658207&r2=658208&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeIncludeBuilderImpl.java
(original)
+++ incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeIncludeBuilderImpl.java
Tue May 20 04:21:58 2008
@@ -91,10 +91,8 @@
             composite.getReferences().addAll(clone.getReferences());
             composite.getProperties().addAll(clone.getProperties());
             composite.getWires().addAll(clone.getWires());
-            if ( composite instanceof PolicySetAttachPoint ) {
-                ((PolicySetAttachPoint)composite).getPolicySets().addAll(((PolicySetAttachPoint)clone).getPolicySets());
-                ((PolicySetAttachPoint)composite).getRequiredIntents().addAll(((PolicySetAttachPoint)clone).getRequiredIntents());
-            }
+            composite.getPolicySets().addAll(clone.getPolicySets());
+            composite.getRequiredIntents().addAll(clone.getRequiredIntents());
         }
     
         // Clear the list of includes



Mime
View raw message