tuscany-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sl...@apache.org
Subject svn commit: r1159624 - /tuscany/sca-java-2.x/trunk/modules/assembly/src/main/java/org/apache/tuscany/sca/interfacedef/impl/InterfaceContractMapperImpl.java
Date Fri, 19 Aug 2011 13:17:08 GMT
Author: slaws
Date: Fri Aug 19 13:17:08 2011
New Revision: 1159624

URL: http://svn.apache.org/viewvc?rev=1159624&view=rev
Log:
TUSCANY-3916 - Correct comment to reflect what I believe is the reality

Modified:
    tuscany/sca-java-2.x/trunk/modules/assembly/src/main/java/org/apache/tuscany/sca/interfacedef/impl/InterfaceContractMapperImpl.java

Modified: tuscany/sca-java-2.x/trunk/modules/assembly/src/main/java/org/apache/tuscany/sca/interfacedef/impl/InterfaceContractMapperImpl.java
URL: http://svn.apache.org/viewvc/tuscany/sca-java-2.x/trunk/modules/assembly/src/main/java/org/apache/tuscany/sca/interfacedef/impl/InterfaceContractMapperImpl.java?rev=1159624&r1=1159623&r2=1159624&view=diff
==============================================================================
--- tuscany/sca-java-2.x/trunk/modules/assembly/src/main/java/org/apache/tuscany/sca/interfacedef/impl/InterfaceContractMapperImpl.java
(original)
+++ tuscany/sca-java-2.x/trunk/modules/assembly/src/main/java/org/apache/tuscany/sca/interfacedef/impl/InterfaceContractMapperImpl.java
Fri Aug 19 13:17:08 2011
@@ -90,9 +90,10 @@ public class InterfaceContractMapperImpl
             }            
             targetLogicalType = (XMLType)target.getLogical();
 
-            // The logical type seems to be null in some cases, e.g. when the 
-            // argument or return type is something like a Map. 
-            // TODO - check when some type give rise to a null logical type
+            // The logical type is null in some cases. This is when the 
+            // runtime can't determine the XML type for a particular type, for
+            // example for a non-JAXB Java bean. This makes interface checking
+            // rather lenient with errors being detected at runtime
             if (sourceLogicalType.getTypeName() == null ||
                 targetLogicalType.getTypeName() == null) {
                 return true;



Mime
View raw message