uima-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marshall Schor <...@schor.com>
Subject Re: svn commit: r596254 - /incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/ecore/Ecore2UimaTypeSystem.java
Date Fri, 30 Nov 2007 15:59:36 GMT
Good points.  I updated UIMA-4 to capture your reasoning about the
tests.  I won't do any changes at this point in our release process, but
will look into this after the release is out (if it comes up high enough
in the priority list :-)  )
-Marshall

Thilo Goetz wrote:
> It would probably make things easier to set svn:eol-style to
> native for source code.  The thing we need to be careful about
> is *not* to set it for our test resources.  Many of our tests
> depend on character offsets in test files, and those get changed
> when different line endings are used on different platforms.
>
> So if you change anything, please make sure to extract the code,
> build and test on windows and at least one non-windows platform.
>
> --Thilo
>
> Marshall Schor wrote:
>   
>> I just noticed that the patch I applied for the CDE also caused all the
>> line endings to be replaced with CR LF.
>>
>> I found this in the Eclipse help for applying patches - see the warning
>> at the end.
>>
>> To apply a patch:
>>
>>    1. Select the resource that the patch was generated on. This resource
>>       should contain the same file revisions as the line-up on which the
>>       patch was generated.
>>    2. From the pop-up menu, select *Team>Apply Patch...*. The Resource
>>       Patcher wizard will open.
>>    3. Indicate where the patch is to be found:
>>          1. /File/ - the patch is in a file on the local file system.
>>             Either type in the full path to the file or use the
>>             *Browse...* button to find the file.
>>          2. /Clipboard/ - the patch is on the clipboard. *Warning:* It
>>             is safer to use a file based patch. Line endings may not be
>>             handled properly if the clipboard is used and the patch was
>>             generated on a different platform (i.e. Linux vs. Windows).
>>
>>
>> Anyone have opinions on if it is important to fix the files in our SVN
>> source that have CR LF back to just LF?
>>
>> There was a Jira issue from a long time ago (
>> https://issues.apache.org/jira/browse/UIMA-4 ) to address this.  That
>> issue suggests setting the svn:eof-style to native, but based on what I
>> see, most of the files in SVN are using just LF for endings.  Eclipse
>> editors handle this kind of line ending just fine, without changing it
>> (except for the apparent issue with patch files on the clipboard).
>>
>> Do people think it's a good idea to set this svn property on our source
>> (and test) files to prevent these problems in the future?
>>
>> -Marshall
>>
>>     

Mime
View raw message