uima-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marshall Schor <...@schor.com>
Subject Re: svn commit: r601682 - /incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/FSIndexComparatorImpl.java
Date Thu, 06 Dec 2007 12:41:28 GMT
Hmmm - this might be broken - for string subtypes (with allowed values) ?

The old code did a subsumes test for these.

-Marshall

twgoetz@apache.org wrote:
> Author: twgoetz
> Date: Thu Dec  6 02:28:01 2007
> New Revision: 601682
>
> URL: http://svn.apache.org/viewvc?rev=601682&view=rev
> Log:
> Jira UIMA-407: use Type.isPrimitive().
>
> https://issues.apache.org/jira/browse/UIMA-407
>
> Modified:
>     incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/FSIndexComparatorImpl.java
>
> Modified: incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/FSIndexComparatorImpl.java
> URL: http://svn.apache.org/viewvc/incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/FSIndexComparatorImpl.java?rev=601682&r1=601681&r2=601682&view=diff
> ==============================================================================
> --- incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/FSIndexComparatorImpl.java
(original)
> +++ incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/FSIndexComparatorImpl.java
Thu Dec  6 02:28:01 2007
> @@ -58,11 +58,7 @@
>    }
>  
>    private boolean checkType(Type t) {
> -    if (this.cas.isIntType(t) || this.cas.isFloatType(t) || this.cas.isStringType(t)
> -            || this.cas.isDoubleType(t) || this.cas.isLongType(t) || this.cas.isShortType(t))
{
> -      return true;
> -    }
> -    return false;
> +    return t.isPrimitive();
>    }
>  
>    public void setType(Type type) {
>
>
>
>
>   


Mime
View raw message