uima-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Holmberg (JIRA)" <uima-...@incubator.apache.org>
Subject [jira] Issue Comment Edited: (UIMA-1747) TikaAnnotator: null pointer exception in MarkupHandler.populateCAS
Date Thu, 01 Apr 2010 18:37:31 GMT

    [ https://issues.apache.org/jira/browse/UIMA-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852496#action_12852496
] 

Greg Holmberg edited comment on UIMA-1747 at 4/1/10 6:35 PM:
-------------------------------------------------------------

Hi Tommaso.  Regarding what is the correct exception to throw, I looked at the callers code
(TIKAWrapper.populateCASfromURL), and it throws CASException, so MarkupHandler.populateCAS
could throw that also without any changes to MarkupHandler.

I'm not sure what the consequences of changing the signature of this method are.  Is it a
real, documented public contract, or is it merely a method marked "public" and the only caller
affected would be TIKAWrapper?  If the latter, then I wouldn't worry about keeping a stable
signature.

If it would affect many callers other than TIKAWrapper, then throwing RuntimeException or
something derived from it makes sense.

      was (Author: holmberg):
    Hi Tommaso.  Regarding what is the correct exception to throw, I looked at the callers
code (TIKAWrapper.populateCASfromURL), and it throws CASException, so MarkupHandler.populateCAS
could throw that also without any changes to MarkupHandler.

I'm not sure what the consequences of changing the signature of this method is.  Is it a real,
documented public contract, or is it merely a method marked "public" and the only caller affected
would be TIKAWrapper?  If the latter, then I wouldn't worry about keeping a stable signature.

If it would affect many callers other than TIKAWrapper, then throwing RuntimeException or
something derived from it makes sense.
  
> TikaAnnotator: null pointer exception in MarkupHandler.populateCAS
> ------------------------------------------------------------------
>
>                 Key: UIMA-1747
>                 URL: https://issues.apache.org/jira/browse/UIMA-1747
>             Project: UIMA
>          Issue Type: Bug
>          Components: Sandbox-TikaAnnotator
>    Affects Versions: 2.3
>            Reporter: Greg Holmberg
>            Priority: Blocker
>         Attachments: UIMA-1747-patch.txt
>
>
> I get the following NPE.
> java.lang.NullPointerException
> 	at org.apache.uima.cas.impl.CASImpl.createFS(CASImpl.java:474)
> 	at org.apache.uima.tika.MarkupHandler.populateCAS(MarkupHandler.java:168)
> 	at org.apache.uima.tika.TIKAWrapper.populateCASfromURL(TIKAWrapper.java:105)
> 	at org.apache.uima.tika.FileSystemCollectionReader.getNext(FileSystemCollectionReader.java:99)
> 	at org.apache.uima.collection.impl.cpm.engine.ArtifactProducer.readNext(ArtifactProducer.java:494)
> 	at org.apache.uima.collection.impl.cpm.engine.ArtifactProducer.run(ArtifactProducer.java:711)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message