uima-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marshall Schor <...@schor.com>
Subject Re: Next release candidate
Date Fri, 03 Dec 2010 18:54:36 GMT
Let's defer these fixes until we get 2.3.1 out - I'm trying to get a release
candidate to go, today :-)

-Marshall Schor

On 12/3/2010 4:24 AM, Tommaso Teofili wrote:
> Well, I agree with you that I don't want too complicated over optimized code
> where it's not needed but I partially disagree since .."abc" + "def"... is
> both slower and uglier and replacing it with ...new
> StringBuilder("abc").append("def")... doesn't seem to me to make it so
> complicated.
> Most part of UIMA code looks good but I think it would be also good to spend
> a few cycles, from time to time, to make it look nicer, that usually
> bringing to more extensible and readable code.
> My 2 cents,
> Tommaso
> 2010/12/3 Jörn Kottmann <kottmann@gmail.com>
>> On 12/3/10 9:48 AM, Tommaso Teofili wrote:
>>> For example in DocumentAnalayzer most of messages are builded like that.
>>> At the moment I found such string concatenation in:
>>> uimaj-cpe: CheckPointConfig, CheckPoint
>>> uimaj-tools: CpmPanel, AnnotationViewerDialog, DocumentAnalyzer,
>>> AnnotationViewerMain
>>> uimaj-ep-configurator: TypeSection, MultiPageEditor
>>> jVinci: ServiceRegistry
>>> if you agree, I'm going to fix them,
>> I actually was only worried about the new tag drawing code
>> in the Cas Editor which is frequently executed and
>> should be a little faster.
>> I think it does not make sense to optimize code
>> too much when the optimization is not needed.
>> Optimizing code makes it  usually more complicated,
>> which only makes sense if it ends up with a noticeable or
>> measureable change in execution time.
>> Jörn

View raw message