uima-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörn Kottmann (JIRA) <...@uima.apache.org>
Subject [jira] Created: (UIMA-2043) SolrCASConsumers initialize method should be refactored
Date Wed, 09 Feb 2011 16:39:57 GMT
SolrCASConsumers initialize method should be refactored
-------------------------------------------------------

                 Key: UIMA-2043
                 URL: https://issues.apache.org/jira/browse/UIMA-2043
             Project: UIMA
          Issue Type: Improvement
          Components: Sandbox
            Reporter: Jörn Kottmann
            Priority: Minor


In the initialize method the following is done:

String solrInstanceTypeParam = String.valueOf(context.getConfigParameterValue("solrInstanceType"));
assert solrInstanceTypeParam != null;

The assert will always be true since String.valueOf never returns a null reference, even when
you pass a null reference to it, it will return the string "null".

getConfigParameterValue can actually return null, and we should fail the initialization if
not all necessary parameters to run it are specified in the descriptor. It should fail
with a meaningful error message.
Using assert is not a safe way to fail the initialization because asserts are usually
disabled. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message