uima-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörn Kottmann (JIRA) <...@uima.apache.org>
Subject [jira] [Commented] (UIMA-2189) Add ASL headers to TextMarker files
Date Tue, 02 Aug 2011 07:22:30 GMT

    [ https://issues.apache.org/jira/browse/UIMA-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13076075#comment-13076075
] 

Jörn Kottmann commented on UIMA-2189:
-------------------------------------

Your patch is a bulk patch, because it is fixing multiple issues. Bulk patches make it difficult
to track and review the changes which have been made to the code base for one issue. Your
patch is 7.4 MB and contains mostly AL headers. In this patch it is now difficult to find
the changes for the other two issues UIMA-2190 and UIMA-2191. 

We are still missing quite some license headers, especially in java files, xml files, resource
files. I suggest that you get RAT, which is an Apache tool to check for license headers and
then try to add headers to all files where it is possible. Maybe there are some text files
which cannot contain a license header, such as test files, readme files, notice files, etc.

Would it be possible for you to split the patch?

> Add ASL headers to TextMarker files
> -----------------------------------
>
>                 Key: UIMA-2189
>                 URL: https://issues.apache.org/jira/browse/UIMA-2189
>             Project: UIMA
>          Issue Type: Task
>          Components: TextMarker
>            Reporter: Jörn Kottmann
>            Assignee: Peter Klügl
>         Attachments: patch.txt
>
>
> All Text Marker files must have the AL 2.0 license header. Add the license header to
all files of the Text Marker system.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message