uima-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Klügl <pklu...@uni-wuerzburg.de>
Subject Re: [VOTE] Apache UIMA TextMarker RC4 AND Composite Repository
Date Mon, 11 Feb 2013 14:15:57 GMT
On 08.02.2013 23:49, Marshall Schor wrote:
> On 2/8/2013 8:02 AM, Peter Klügl wrote:
>> After another round of reviewing:
>> - (known issue) additional files LICENSE.txt and NOTICE.txt in
>> textmarker-ep-engine-2.0.0\META-INF. However, files LICENSE and NOTICE are OK.
> I poked around and saw that this happens when the unpacking of dependent JARs
> into target/classes is done.  Some of these Jars have their own MANIFEST
> directory, and at least one of them has a LICENSE.txt and NOTICE.txt files (the
> org.apache.commons commons-lang3 version 3.1 Jar).
>
> Of course, any of the included JARs could have their own LICENSE and NOTICE
> files, and they would "overlay" one another during the unpacking.  This is why I
> had earlier suggested finding a way to not do the unpacking.  :-)  I finally
> tracked down where we did a change like this in UIMA-2176; if you want (at some
> point) to pursue doing something similar, it could provide an example.  The
> separate build for OSGi bundles was removed in UIMA-2184.  You can see the build
> in the uima-wide parent pom in the profile with id "build OSGi bundle for
> annotator".
>
> Dependent jars are put into a /lib/ directory without unpacking them.  Then, an
> instruction:
>
> <Bundle-ClassPath> is set up to include those Jars.
>
> This approach lets each Dependent Jar keep its own LICENSE and NOTICE files :-).
>
> I'm unsure how important it is to avoid having the embedded/unpacked JARs have
> their LICENSE/NOTICE files potentially overridden. I suppose if all of the
> embedded JARs were manually checked to "bubble up" any LICENSEs / NOTICEs, then
> it would be OK.   If there were no LICENSEs / NOTICEs in an enbedded JAR, then I
> think we would need to get this info from the project itself.  You've probably
> done all this already; I'm just coming behind and checking...

I have already tried something like <Bundle-ClassPath> when I created 
the build process for the engine plugin, but could not resolve all problems.

I will take a closer look at the issues you mentioned. And maybe I will 
get Richard's changes in UIMA-2560 up and running.

Peter





> -Marshall


Mime
View raw message