uima-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marshall Schor (JIRA)" <...@uima.apache.org>
Subject [jira] [Commented] (UIMA-5308) Fix potential NPE in ProcessContainer_Impl.java
Date Fri, 10 Feb 2017 16:02:41 GMT

    [ https://issues.apache.org/jira/browse/UIMA-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861451#comment-15861451
] 

Marshall Schor commented on UIMA-5308:
--------------------------------------

what about the trailing "&& !exists" in that if clause? should it be an "OR" instead
of an "and", too?

> Fix potential NPE in ProcessContainer_Impl.java
> -----------------------------------------------
>
>                 Key: UIMA-5308
>                 URL: https://issues.apache.org/jira/browse/UIMA-5308
>             Project: UIMA
>          Issue Type: Bug
>          Components: Collection Processing
>            Reporter: Jerry Cwiklik
>            Assignee: Jerry Cwiklik
>             Fix For: 3.0.0SDK-beta, 2.10.0SDK
>
>
> -Marshall ran a code checker (FindBugs?)- Marshall examined the Jenkins build reports,
which included a "PMD" report, which had some "red" notations (more serious), which found
a bug that can cause NPE in ProcessingContainer_Impl.java in the CPE.
> The following :
>         if (( (filterExpression.getOperand() == null
>                && filterExpression.getOperand().getOperand() == null) &&
!exists)
> should be:
>  
>         if (( (filterExpression.getOperand() == null
>               || filterExpression.getOperand().getOperand() == null) && !exists)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message